Skip to content

Loading…

DDC-2420: [GH-656] [DDC-2235] Fix for using a LEFT JOIN onto an entity with single table inheritance #3134

Closed
doctrinebot opened this Issue · 7 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of tarnfeld:

Url: #656

Message:

Possible fix for the bug DDC-2235. I'd love to hear some opinions on whether this is the right way to go about this issue. I'm not particularly familiar with the internals of doctrine so there may be a better solution.


The issue is when using DQL to perform a left join on an entity using single
table inheritance, doctrine tries to insert an IN() predicate into the WHERE
clause for all of the discriminator values. That makes sense and is valid, so
it would be wrong to remove that behaviour.

However when using a left join having an IN() in the main where clause makes
the LEFT JOIN pretty much useless, as it implicitly creates a WHERE NOT NULL
clause. This commit attempts to fix that by including an OR IS NULL in the
query if the join is a LEFT JOIN.

I've added some regression tests to ensure this bug never creeps back in. They fail on master (highlighting the bug) and pass after these commits have been applied. I've also included a couple of other queries as tests to be sure only this one case has been affected.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-656] was closed:
#656

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-758] was closed:
#758

@doctrinebot

Comment created by @ocramius:

Handled in #758 ( DDC-2235 )

@doctrinebot

Issue was closed with resolution "Incomplete"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-656] was closed:
doctrine/dbal#656

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-758] was assigned:
doctrine/dbal#758

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-758] was closed:
doctrine/dbal#758

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.4 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.