Skip to content

Loading…

DDC-2507: [GH-698] Fix for [DDC-2506] CTI JOINs and WITH conditionals #3229

Closed
doctrinebot opened this Issue · 6 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of mattjanssen:

Url: #698

Message:

http://www.doctrine-project.org/jira/browse/[DDC-2506](http://www.doctrine-project.org/jira/browse/DDC-2506)

Moved the SqlWalker::walkConditionalExpression() out of walkJoin() and into walkJoinAssociationDeclaration() after the base class JOIN but before the _generateClassTableInheritanceJoins(), thus allowing WITH conditions in Class Table Inheritance joins to apply correctly.

On a side note, I'm not able to get phpunit to run (even on a clean Master) so I'm leaving the testing up to Travis.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-698] was closed:
#698

@doctrinebot

Issue was closed with resolution "Incomplete"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-708] was closed:
#708

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-698] was assigned:
doctrine/dbal#698

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-708] was closed:
doctrine/dbal#708

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-708] was assigned:
doctrine/dbal#708

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.