DDC-2533: [GH-710] Fix extra lazy get #3257

Closed
doctrinebot opened this Issue Jun 27, 2013 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of sandermarechal:

Url: #710

Message:

I made a big mistake in PR #706, my apologies. The get() function in the OneToManyPersister and ManyToManyPersister did not add the collection owner to the load query.

The first commit in this PR fixes this for the OneToMayPersister.

I could not find a way to fix this for the ManyToManyPersister. Problem is that you can only use conditions on the owning side of a ManyToMany relation, not on the inverse side. Code like load(array($mapping['inversedBy'] => $coll->getOwner()), ...) gave an ORMException.

Therefor, the second commit in this PR removes the extra-lazy-get for ManyToMany relations. If anyone has any ideas how to make this work for the ManyToMany side, please let me know.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-710] was closed:
#710

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-710] was assigned:
doctrine/dbal#710

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-710] was closed:
doctrine/dbal#710

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment