Skip to content

Loading…

DDC-2589: [GH-746] Makes children of AbstractQuery non-final. #3318

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of elyobo:

Url: #746

Message:

b66d530 made these classes final, but there is no rationale for this change given in the commit log. Leaving this as final makes it impossible to mock and makes testing some areas of code difficult (or impossible).

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-746] was closed:
#746

@doctrinebot

Issue was closed with resolution "Won't Fix"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-746] was closed:
doctrine/dbal#746

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-746] was assigned:
doctrine/dbal#746

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.