Skip to content

Loading…

DDC-2762: [GH-829] [DDC-2761] Fixed UnitOfWork::recomputeSingleEntityChangeSet exception with STATE_REMOVED entities #3508

Closed
doctrinebot opened this Issue · 5 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of giosh94mhz:

Url: #829

Message:

Hi!

I found a bug in UnitOfWork::recomputeSingleEntityChangeSet for the branch 2.4, which is also present in master. I didn't tested previous stable versions, but the bug may also apply.

The problem is that an exception is thrown on flush (at least when using a single entity flush), if an entity is in deleted state and also with pending modification and a preUpdate listener configured.

I've attached a patch and a unit tests (I've tweeked a previous preUpdate method used for testing, but everythings pass).

Anyway, this result in an UPDATE followed by a DELETE statement. An entity in STATE_REMOVED shouldn't need to be updated, and should be immediately deleted. If you agree, I could implement this behaviour myself (as long I manage not to break unit tests).

PS: sorry for the commit on the 2.4 branch :)

@doctrinebot

Comment created by giosh94mhz:

The DoctrineBot didn't read "[DDC-2761]" in the title of the pull request, so it has opened a new bug. The test class now refers to DDC-2761 as ticket number, and there is a duplicate ticket.

Sorry for the extra work guys, but I've opened a github account just to send you this patch! :-) Next time I'll RTFM, promise!

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-845] was closed:
#845

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-829] was closed:
#829

@doctrinebot

Comment created by @beberlei:

This was fixed with DDC-2790

@doctrinebot

Issue was closed with resolution "Duplicate"

@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.