Skip to content

Loading…

DDC-3: Support for CASE expressions in DQL #3764

Closed
doctrinebot opened this Issue · 8 comments

2 participants

@doctrinebot

Jira issue originally created by user romanb:

CASE expressions should be supported in DQL similarly to the definition found in 4.6.17.3 of the JPA 2.0 specification.

Steps: 1) Adjust the BNF
2) Adjust the Parser according to the changed BNF
3) Adjust the SqlWalker? to produce the correct SQL

@doctrinebot

Comment created by romanb:

test

@doctrinebot

Comment created by romanb:

The BNF and Parser has already been largely prepared for that.

@doctrinebot

Comment created by @guilhermeblanco:

Added all Lexer keywords to it. It was breaking some use cases.

Parsing can be easily done. How far is Walker generation far from an acceptable state?

@doctrinebot

Comment created by @beberlei:

its a 2.1 change, so we can delay that for now or not? adding the keyword is a good idea though, maybe we should think about some other keywords that we potentially need in the future?

@doctrinebot

Comment created by romanb:

I will try to finish this for 2.1.

@doctrinebot

Comment created by @guilhermeblanco:

In this commit: 816ce41
And documented in this commit: doctrine/orm-documentation@189c729

This support was FINALLY included. =)

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.2 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.