Skip to content

Loading…

DDC-3022: JOIN without association generates invalid SQL #3790

Closed
doctrinebot opened this Issue · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user mnapoli:

I saw in the documentation than since Doctrine 2.4 we could join without associations, using fields.

However I tried it and it generates invalid SQL (I use master). Here is an example:

SELECT a
FROM Namespace\Article a
JOIN Namespace\Authorization authorization WITH a.id = authorization.entityId

Generates the following SQL:

SELECT a0*.id AS id0 FROM Article a0_ INNER JOIN Authorization a1_ AND (a0_.id = a1*.entityId)

As you can see, instead of "INNER JOIN ... ON ..." we have "INNER JOIN ... AND ..." which is invalid.

I can't say if it's a regression of 2.5, or already in 2.4. I can't test my project with 2.4 because I used embedded objects.

@doctrinebot

Comment created by @ocramius:

I wrote a test at https://github.com/doctrine/doctrine2/compare/hotfix;[DDC-3022](http://www.doctrine-project.org/jira/browse/DDC-3022)-wrong-arbitrary-join-sql and it doesn't look like the bug is there.

Check your mappings and verify that everything is correct, or alter the given test case to make it fail.

@doctrinebot

Comment created by mnapoli:

Thank you for trying and sorry for wasting your time -_- I had forgotten an empty discriminator map on the "Authorization" class. For my defense the error was kind of weird ;)

It's all good, no bug here.

@doctrinebot

Issue was closed with resolution "Invalid"

@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.