Skip to content

Loading…

DDC-3028: [GH-978] [DDC-2987] Enable empty prefixes for inlined embeddable #3796

Closed
doctrinebot opened this Issue · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of AntonStoeckl:

Url: #978

Message:

This fixes [DDC-2987]

This makes it possible to map a field from an embeddable to a database field with the same name, without any prefix added.

Example:

  • an embeddable object "Id" with a property "id"
  • per default this would map inline to id_id
  • supplying null or '' as columnPrefix does not work due to the ! empty() check
  • with my little change, if columnPrefix : false is supplied in the mapping config this will now map to a db column "id"

To build Ids as ValueObjects is a very common approach in DDD, so ihmo this is a must have.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-978] was closed:
#978

@doctrinebot

Comment created by @guilhermeblanco:

Merged: 383604d

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.5 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.