Skip to content

Loading…

DDC-3044: [GH-986] Add last modified time for metadata #3814

Closed
doctrinebot opened this Issue · 3 comments

3 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of c960657:

Url: #986

Message:

This patch improves performance during development and does not affect production performance.

Currently, enabling the metadata cache during development gives a remarkable performance boost, but it requires that you manually flush the metadata cache when the metadata has been changed. When running console commands such as console orm:schema-tool:update (see #979).

With this change, metadata entries fetched from cache are checked for freshness using a quick last modified check. This is much faster than loading the actual metadata using the metadata driver. This allows you to enable the metadata cache during development without the need for manually flushing the metadata cache.

This PR is part 1 of 2. Part 2 is for the doctrine/common repository.

If this PR is accepted, it allows us to optimize the auto-generate proxy classes feature by comparing the last modified time for the metadata with the modified timestamp of the generated file.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-986] was labeled:
#986

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-986] was assigned:
#986

@beberlei beberlei was assigned by doctrinebot
@Ocramius
Doctrine member

Closing as per discussion in #986

@Ocramius Ocramius closed this
@beberlei beberlei was unassigned by Ocramius
@Ocramius Ocramius self-assigned this
@Ocramius Ocramius added the Won't Fix label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.