DDC-3058: [GH-993] Update JoinColumn.php #3829

Closed
doctrinebot opened this Issue Mar 28, 2014 · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of KamilKopaczyk:

Url: #993

Message:

If $referencedColumnName = 'id' by default, it doesn't make sense to make checks like:

if (empty($joinColumn['referencedColumnName'])) {

(ClassMetaDataInfo file)


Considering you map your column

@ORM\JoinColumn(onDelete="CASCADE")

You'll get JoinColumn with 'id' value, which doesn't let doctrine use naming strategies for referenced column names

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-993] was closed:
#993

@doctrinebot

Comment created by @guilhermeblanco:

Unfortunately, while this is true for Annotations (it can never be empty), it is not for XML, YAML and PHP itself.
When using Annotations, we keep convention over configuration as the standard, providing the default id, while we require further configuration on other drivers.

Closing as invalid.

@doctrinebot

Issue was closed with resolution "Invalid"

@doctrinebot doctrinebot added this to the 2.5 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment