DDC-3114: [GH-1026] Remove some redundant clauses #3891

Closed
doctrinebot opened this Issue May 2, 2014 · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of flack:

Url: #1026

Message:

The objectmanager insertion logic was identical in the if and else clauses, so I replaced both occurences with one directly after the else block closes. It is semantically identical but a little more readable, especially since the method has more than 250 lines (and a cyclomatic complexity of 100 or so :-)) as it is.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1026] was closed:
#1026

@doctrinebot

Comment created by @ocramius:

Merged: 94837a0

@doctrinebot

Issue was closed with resolution "Fixed"

@Ocramius Ocramius was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.5 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment