Skip to content

DDC-359: Specified, but empty CLI Options --option= causes Notice undefined offset: 0 [Test case for CliController included] #4411

Closed
doctrinebot opened this Issue Feb 21, 2010 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user naderman:

Specified, but empty CLI Options --option= cause a Notice (undefined offset: 0)

This problem also exists in trunk.

What I ran:

naderman@Chaumont:~/projects/doctrine/Doctrine-trunk/tools/sandbox$ ./doctrine Orm:generate-proxies --class-dir=

Expected output:

Doctrine Command Line Interface

No classes to process.

Actual output:

PHP Notice:  Undefined offset: 0 in /home/naderman/projects/doctrine/Doctrine-trunk/lib/Doctrine/Common/Cli/CliController.php on line 230
PHP Stack trace:
PHP   1. {main}() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine:0
PHP   2. include() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine:4
PHP   3. Doctrine\Common\Cli\CliController->run() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine.php:12
PHP   4. Doctrine\Common\Cli\CliController->_processArguments() /home/naderman/projects/doctrine/Doctrine-trunk/lib/Doctrine/Common/Cli/CliController.php:127
Doctrine Command Line Interface

Orm:generate-proxies => The supplied configuration uses the annotation metadata driver. The 'class-dir' argument is required for this driver.

I decided to write a patch and a test case for the issue but it turns out there aren't any tests for CliController, so I added some. You can find the result attached. Not sure if you can still call this "unit" test but it looks to me like the best you can currently do and should work quite well.

I also came across another problem in CliController where it incorrectly refers to AbstractPrinter, rather than Printers\AbstractPrinter which is now included in the patch for the original bug.

I'm not sure what your guideline on @author tags is, I added them to the test case and the TaskMock class now, but feel free to remove them if you like. Some of Doctrine's files seem to have them and some not.

@doctrinebot

Comment created by @jwage:

Thanks for the bug report and awesome patch/test case!

@doctrinebot

Issue was closed with resolution "Fixed"

@jwage jwage was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0-BETA1 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.