DDC-421: Add getFieldValue on ClassMetadata class #4920

Closed
doctrinebot opened this Issue Mar 13, 2010 · 5 comments

2 participants

@doctrinebot

Jira issue originally created by user seldaek:

I would like the attached patch to be applied since it allows you to use the ClassMetadata in a much more obvious and consistent way.

i.e. it allows you to do :
{quote}
$this->_class->setFieldValue($entity, $field, 35);
$this->_class->getFieldValue($entity, $field);
{quote}

instead of the current:
{quote}
$this->_class->setFieldValue($entity, $field, 35);
$this->_class->getReflectionProperty($field)->getValue($entity);
{quote}

I am using the new style already in the NestedSet extension so it would be good if you could apply it fairly quickly if you agree.

@doctrinebot

Comment created by @beberlei:

please use $class->reflFields[$field]->getValue()

@doctrinebot

Issue was closed with resolution "Won't Fix"

@doctrinebot

Comment created by romanb:

I think its OK to add this method, otherwise we would need to remove setFieldValue also for consistency. As an explanation for Jordi why Benjamin mentioned using reflFields is that we use this public property inside Doctrine for performance reasons (access + serialization) but for user code its probably mostly OK to use the more explicit variants.

This method will be incuded in my next commit where I remove a lot of unnecessary other boilerplate.

@doctrinebot

Comment created by seldaek:

Good, thank you, I was getting ready for war when I read Benjamin's response, but I'm glad someone got what I meant :) I'll keep using my hacked version until it's applied then.

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0-BETA1 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment