Skip to content

Loading…

DDC-488: Create documentation for PHP mapping driver. #4992

Closed
doctrinebot opened this Issue · 6 comments

2 participants

@doctrinebot

Jira issue originally created by user romanb:

The PHP mapping driver is currently not documented but should be.

@doctrinebot

Comment created by @beberlei:

In that regard the question if we should change the PhpDriver not to include another file for the metadata loading, but call a static loadMetadata method on each entity that accepts the ClassMetadata instance.

@doctrinebot

Comment created by @jwage:

I think we should allow both. Either offer a new driver type or add an option to PhpDriver?

@doctrinebot

Comment created by romanb:

I think an option on PHPDriver would be enough.

@doctrinebot

Comment created by @beberlei:

What the PHP Driver currently not has compared to other drivers is validation. There should be some additional checks after the ClassMetadata was filled.

@doctrinebot

Comment created by @jwage:

I added a StaticPHPDriver here http://github.com/jwage/doctrine2/commit/27a0058b89d5fc4b413f0b1a7542c57cec60e1c6

We can't add a option to PHPDriver since it extends from AbstractFileDriver and requires something a little more custom.

@doctrinebot

Issue was closed with resolution "Fixed"

@jwage jwage was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.0 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.