Skip to content

Loading…

DDC-571: IntegerType - NULL in datbase should be NULL not 0 #5077

Closed
doctrinebot opened this Issue · 3 comments

1 participant

@doctrinebot

Jira issue originally created by user drevolution:

I think that IntegerType::convertToPHPValue() should return NULL if we have NULL value in database. So insted

return (int) $value;

there will be

return is_null($value) ? NULL : (int) $value;

Or there could be even some sophisticated checking if column is nullable.

@doctrinebot

Comment created by shurakai:

I've fixed this and pushed it into http://github.com/Shurakai/doctrine2

Therefore, Roman might pull it back into the repo.

@doctrinebot

Comment created by romanb:

@Christian: Thanks.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.0-BETA2 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.