Skip to content

Loading…

DDC-673: yaml metadata allows integer(X) types but ignores the X #5183

Closed
doctrinebot opened this Issue · 5 comments

1 participant

@doctrinebot

Jira issue originally created by user gnat:

When using the yaml mapping driver, it is possible (and in fact used by the yaml exporter) to have type: integer(X). doctrine never complains, however it always creates mysql int(11) fields regardless of the X. It should either cause an error at some point (like it does in the annotation driver according to romanb) or observe the X when creating the integer size.

@doctrinebot

Comment created by shurakai:

I think we should throw an error in that case and change the yaml exporter to observe this rule.

Roman, would that be okay? If so, I'll try to fix it before the next beta.

@doctrinebot

Comment created by romanb:

Yes, I guess that would be fine.

@doctrinebot

Comment created by @beberlei:

Fixed

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.0-RC1 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.