Skip to content

Loading…

DDC-687: Add New Entity Attribute "idGetter" to allow accessing the ID without triggering lazy-load #5197

Closed
doctrinebot opened this Issue · 4 comments

1 participant

@doctrinebot

Jira issue originally created by user @beberlei:

Often people present us with the use-case that they want to access the ID of a proxy without loading it.

This has lead to several ugly solutions like mapping the ID to an object and as a foreign key field. There currently exists a simple solution for this:

$id = $em->getUnitOfWork()->getEntityIdentifier($entity->getRelatedProxy());

However we could add a new property here called "idGetter" that would take the name of a method.

During Proxy Generation then this method is created with magic functionality that:

  1. In case of Single Primary Key returns the single value
  2. In case of Composite Primary Key returns an array of the values in their UoW internal order
  3. Throw an Exception if the method does not exist on the original object
@doctrinebot

Comment created by stefanklug:

What about an @IdGetter annotation. A function instrumented like this would not trigger the lazy load within the proxy.

Something like

class Entity {
    /*** @Id ***/
    private $id;

    /*** @IdGetter ***/
    public function getId() {
       return $this->id;
    }
}

would then result in the proxy implementation

class EntityProxy extends Entity {

    public function getId() {
        if (!$this->*_isInitialized_*) {
            return $this->_identifier;
         } else {
             return parent::getId();
        }
    }
}

After reading the original post I realized that it proposed nearly the same thing. Nevertheless I'll leave it here for clarity. I still think that an annotation on a function would be better, than an annotation which gets the function name as a parameter.

Regards Stefan

@doctrinebot

Comment created by @beberlei:

$this->_identifier is an array.

@doctrinebot

Comment created by @beberlei:

This was implemented in 2.2 by detecting when this can be done on a getId() call automatically.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.2 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.