DDC-688: Original Entity Data gets overridden by the change set #5198

Open
doctrinebot opened this Issue Jul 12, 2010 · 4 comments

1 participant

@doctrinebot

Jira issue originally created by user jasper:

When changing data in an entity, the UnitOfWork will call computeChangeSet on a flush event. If there is a changeset, the original data ($this->*originalEntityData) gets overridden by the new data. However, the *originalEntityData should hold the original data, that was present at the time the entity was reconstituted from the database. This does no longer hold now.

I think this can simply be fixed by commenting this line, however I do not know of any consequences this may bring with it:

$this->_originalEntityData[$oid] = $actualData; (in computeChangeSet, after if( $changeSet ));

Anyway, I ran into this problem while trying to retrieve the original data at the onFlush event of an update.

@doctrinebot

Comment created by romanb:

This is actually currently expected. You can not get access to the original data in the onFlush event right now. I'm not saying that this will never be possible but it is simply the way it works at the moment.

@doctrinebot

Comment created by jasper:

Does this mean that it is currently impossible to implement a Versionable mechanism using snapshots?

@doctrinebot

Comment created by @beberlei:

You can hold a map of them yourself if your listener also implements the "postLoad" event:

$entity = $args->getentity();
$this->originalData[spl*object*hash($entity)] = $args->getEntityManager()->getUnitOfWork()->getOriginalData($entity);
@doctrinebot

Comment created by @beberlei:

Changed into possible improvement for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment