DDC-704: Inheritance-type with no discriminator-column results in SQL Error #5217

doctrinebot opened this Issue Jul 20, 2010 · 4 comments

2 participants


Jira issue originally created by user cmealey:

On an entity (XML mapping atleast) if there is an inheritance-type set but no discriminator-column(s) set the resulting query will have an extra comma at the end of the field list or occasionally (based on inheritance-type) a table alias without a fieldname.

The correct solution would be to throw an exception during the parsing of the mapping that would indicate the inheritance-type is set but no discriminator-columns exist.


Comment created by cmealey:

Moving this from Major to Minor as a correctly mapped entity works fine, the bug is in the error reporting, not the functionality


Comment created by @beberlei:

Implemented better validation


Issue was closed with resolution "Fixed"


Comment created by mridgway:

I can't help but feel that the validation should be implemented outside of the metadata drivers. To me the driver shouldn't require the discriminator map to be present because it limits the ability to add discriminators in other ways.


I use annotations for my models, but I don't set the discriminator maps using the annotations driver, instead I use the loadClassMetadata event to fill in the discriminatorMap from configs or a database. Perhaps this is a job for a custom metadata driver, but I still can't help but feel that the metadata driver shouldn't be the one making these validations, it should be when you try to use the inheritance-mapped model.

Edit: To clarify the situation: I now get mappingException::missingDiscriminatorMap exception because my model annotations don't have a @DiscriminatorMap, but they would be loaded with the loadClassMetadata function.

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0-BETA4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment