Skip to content

Loading…

DDC-827: Class Table Inheritance is broken when child classes have the same properties #5346

Closed
doctrinebot opened this Issue · 4 comments

1 participant

@doctrinebot

Jira issue originally created by user nicokaiser:

I create one Superclass and several Subclasses. The subclasses have properties with the same name (but as I also want to have Subclasses without these properties, this is the only elegant construction), in this example "name".

Now when I select the Superclass, I get all Subclass entities, but the "name" property is not hydrated correctly:

<?php

namespace Entities;

/****
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="type", type="integer")
 * @DiscriminatorMap({ "1" = "Subclass1", "2" = "Subclass2" })
 */
class Superclass
{
    /*** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") **/
    public $id;
}

/*** @Entity **/
class Subclass1 extends Superclass
{
    /*** @Column(type="string") **/
    public $name;
}

/*** @Entity **/
class Subclass2 extends Superclass
{
    /*** @Column(type="string") **/
    public $name;
}

/** **/

$sub1 = new Subclass1;
$sub1->name = 'sub1name';
$em->persist($sub1);

$sub2 = new Subclass2;
$sub2->name = 'sub2name';
$em->persist($sub2);

$em->flush();
$em->clear();

$query = $em->createQuery('SELECT s FROM Entities\Superclass s');
foreach ($query->execute() as $s) {
    echo 'name = ' . $s->name . PHP_EOL;
}

Output:

name = sub2name
name = 

The SQL however seems correct, both(!) "name" columns are selected. This seems to be a bug in hydration.

@doctrinebot

Comment created by @beberlei:

Quoting from the Docs, chapter "Architecture" on the requirements of entities (and inheritance):

Any two entity classes in a class hierarchy that inherit directly or indirectly from one another must not have a mapped property with the same name. That is, if B inherits from A then B must not have a mapped field with the same name as an already mapped field that is inherited from A.```
@doctrinebot

Issue was closed with resolution "Invalid"

@doctrinebot

Comment created by literal:

Please reopen this issue. I can can confirm it and Benjamin's reason for rejecting it is invalid.

The two classes in the example are in neither directly nor indirectly inheriting from one another. They just happen to be siblings, i. e. they have the same superclass.

And to pre-empt the argument: It is not always bad design to have two classes in a hierarchy that have an identically named property. At least as long as PHP does not allow for horizontal re-use via traits or such.

Take this scenario:

SuperClass
|
<ins>- SubClassA
|  </ins>- SubSubClass1
|  <ins>- SubSubClass2
|
</ins>- SubClassB
   <ins>- SubSubClass3
   </ins>- SubSubClass4

Now if the need arises to have a property 'foo' on both SubSubClass1 and SubSubClass4, and 'foo' shall not be part of the top-most super class, because it makes no sense in any of the other classes, then we unfortunately have to repeat ourselves or employ some bad magic which certainly cannot be mapped with Doctrine anyway.

@doctrinebot

Comment created by @beberlei:

There is another open issue that handles this issue. Its indeed a bug.

@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.