New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM support #6424

Closed
lcobucci opened this Issue May 5, 2017 · 11 comments

Comments

8 participants
@lcobucci
Member

lcobucci commented May 5, 2017

We're struggling to support HHVM properly on our projects:

So it's time to rethink if we still want to guarantee HHVM support, the reasons are:

  1. Even though we managed to run HHVM 3.15 on travis it was impossible to install the dependencies (we should give it a try on HHVM 3.18 however I'm not sure how often HHVM users upgrade stuff)
  2. We want to use new PHP features but HHVM is not being able to keep up the pace updates and they still have a list of PHP 5 and 7 incompatibilities
@Ocramius

This comment has been minimized.

Member

Ocramius commented May 5, 2017

Overall, I feel bad for dropping HHVM support, but lack of latest versions by default on CI, as well as incompatibilities with PHP 5, 7, 7.1 are starting to become an issue. Community usage is also very low, since PHP 7 made most interactions as fast as on HHVM.

We need to drop it though, as we need to bump the minimum version to PHP 7.1 anyway.

@alcaeus

This comment has been minimized.

Member

alcaeus commented May 5, 2017

Pinging @Seldaek - he did publish some HHVM stats from Packagist a while back and mentioned in IRC he'd post some current numbers soon. Quote:

last I checked it was less hhvm than php5.3 IIRC

@Majkl578

This comment has been minimized.

Member

Majkl578 commented May 5, 2017

Here: composer/composer#6230 (comment)

last time I checked there was less HHVM than PHP 5.3 users of composer, about 0.4% or smth IIRC, so not really worth the trouble I would say.


Maybe someone from Facebook could share their vision regarding compatibility, but it's been years and even many PHP 5 bugs are still unfixed, not even taking 7.0/7.1 into consideration. There is still ~250 open issues marked PHP 5 incompatibility and another ~75 marked PHP 7 incompatibility. There are also 43 issues marked wontfix which are PHP 5 incomatiblities.
I initially sent some bugfixes and another bunch of issues to HHVM, but now I just have a feeling that HHVM has its own path with PHP compatibility not being a priority.

Btw Symfony still seems to actively ship HHVM support, it'd be interesting to know their point of view, regarding HHVM + Symfony 4.

@theofidry

This comment has been minimized.

theofidry commented May 5, 2017

@Majkl578 Symfony doesn't provide any guarantee for HHVM, but accept fixes for it. Cf. symfony/symfony#18922

@Majkl578

This comment has been minimized.

Member

Majkl578 commented May 5, 2017

@theofidry: Thanks for the link; Symfony doesn't have HHVM in allowed failures so they apparently still do care enough. :)

@lcobucci

This comment has been minimized.

Member

lcobucci commented May 7, 2017

@Ocramius since we had a blogpost about the HHVM roadmap should we write something again?

@Seldaek

This comment has been minimized.

Member

Seldaek commented May 7, 2017

@KennedyTedesco

This comment has been minimized.

KennedyTedesco commented May 7, 2017

Laravel doesn't follow HHVM since: laravel/framework#14530

@szymach

This comment has been minimized.

szymach commented May 12, 2017

It could be dropped for version 3 and reintroduced if there really will be a demand. Something I highly doubt, of course.

I believe this project does not need things dragging it down and that what HHVM support currently is - a minor feature requiring a lot of work, postponing important features.

@Majkl578

This comment has been minimized.

Member

Majkl578 commented May 12, 2017

I actually don't think this would have to wait for next major. Similarly to the PHP versions which are dropped/bumped in minor versions too...

@lcobucci lcobucci self-assigned this May 30, 2017

@lcobucci lcobucci added this to the 2.6.0 milestone May 30, 2017

@lcobucci lcobucci added Improvement and removed Question labels May 30, 2017

@lcobucci lcobucci added this to Backlog in ORM v2.6.x May 30, 2017

@lisachenko lisachenko referenced this issue Jun 7, 2017

Closed

Compatibility with HHVM #143

10 of 10 tasks complete

@lcobucci lcobucci moved this from Backlog to In Progress in ORM v2.6.x Jun 19, 2017

@Ocramius

This comment has been minimized.

Member

Ocramius commented Jun 20, 2017

Handled in #6507 (for ORM)

@Ocramius Ocramius closed this Jun 20, 2017

@lcobucci lcobucci moved this from In Progress to Review in ORM v2.6.x Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment