New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optimized contains in LazyCriteria #1032

Merged
merged 7 commits into from Jun 21, 2014

Conversation

Projects
None yet
5 participants
@bakura10
Member

bakura10 commented May 17, 2014

Hi,

This continue my work on the LazyCriteria and include a support for optimized contains that does not initialize the full collection when checking if a record exists in a collection.

Please note that I had to modify the exists method signature in EntityInterface. I'm not sure this is a problem because, as @Ocramius said in the ManyToMany thread, custom persisters is not supported. However, I added a small note to be sure ;).

@doctrinebot

This comment has been minimized.

Show comment
Hide comment
@doctrinebot

doctrinebot May 17, 2014

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3129

We use Jira to track the state of pull requests and the versions they got
included in.

doctrinebot commented May 17, 2014

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3129

We use Jira to track the state of pull requests and the versions they got
included in.

@bakura10 bakura10 changed the title from Add support for optimized contains to Add support for optimized contains in LazyCriteria May 17, 2014

@bakura10

This comment has been minimized.

Show comment
Hide comment
@bakura10

bakura10 May 17, 2014

Member

Thanks, sorry it was PhpStorm refactoring that messed with it :).

Member

bakura10 commented May 17, 2014

Thanks, sorry it was PhpStorm refactoring that messed with it :).

Show outdated Hide outdated UPGRADE.md Outdated
@bakura10

This comment has been minimized.

Show comment
Hide comment
@bakura10

bakura10 May 18, 2014

Member

Hi @guilhermeblanco ,

I've looked at usages and it appears the extraConditions was only used in one place. Therefore, I modified the signature to enforce Criteria only in the method. Do you prefer it like this?

Member

bakura10 commented May 18, 2014

Hi @guilhermeblanco ,

I've looked at usages and it appears the extraConditions was only used in one place. Therefore, I modified the signature to enforce Criteria only in the method. Do you prefer it like this?

guilhermeblanco added a commit that referenced this pull request Jun 21, 2014

Merge pull request #1032 from bakura10/optimized-contains
Add support for optimized contains in LazyCriteria

@guilhermeblanco guilhermeblanco merged commit 38187a3 into doctrine:master Jun 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bakura10 bakura10 deleted the bakura10:optimized-contains branch Jun 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment