Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

findByXXX does not accept orderBy/limit/offset #115

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mpdeimos commented Sep 2, 2011

Our modification to pass findByXXX functions orderBy/limit/offset params for entity repositories like one is used from normal findBy function.

We're using an if cascade in favor of the call_user_function_array since the latter is considered as slow.

PS: If i need to target this pull request to your master, I'll resubmit - it's just that we're building against a stable codebase.

Owner

guilhermeblanco commented Oct 17, 2011

Idea seems very great, but your code needs some polish. @beberlei could you please look into this one?

Contributor

mpdeimos commented Oct 17, 2011

thx, (w/o looking at the code) a better solution for the if-cascade might be always calling the 4 param method and pass dummy params (null/array()) to indicate missing arguments of findByXXX

Member

asm89 commented Oct 17, 2011

If we introduce this new functionality, there should also be tests for it.

Member

asm89 commented Mar 11, 2012

Merged and added tests here 39ad876 and 3faa1a7.

Thanks!

@asm89 asm89 closed this Mar 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment