Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify @DiscriminatorMap requirement #1516

Merged
merged 1 commit into from Oct 2, 2015
Merged

Conversation

brabeji
Copy link
Contributor

@brabeji brabeji commented Sep 25, 2015

When trying to setup MTI with doctrine, this was always the sentence where I stopped reading as it seems useless if you are forced to specify list of children when you don't even know them. Today I accidentaly read further and found out that this is not necessary.

When trying to setup MTI with doctrine, this was always the sentence where I stopped reading as it seems useless if you are forced to specify list of children when you don't even know them. Today I accidentaly read further and found out that this is not necessary.
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3915

We use Jira to track the state of pull requests and the versions they got
included in.

@brabeji brabeji changed the title Clarify @DiscriminatorMap reqirement Clarify @DiscriminatorMap requirement Sep 25, 2015
@Ocramius Ocramius self-assigned this Oct 2, 2015
Ocramius added a commit that referenced this pull request Oct 2, 2015
Clarify @DiscriminatorMap requirement
@Ocramius Ocramius merged commit 5c6f0ed into doctrine:master Oct 2, 2015
@Ocramius
Copy link
Member

Ocramius commented Oct 2, 2015

@brabeji thanks!

@holtkamp
Copy link
Contributor

holtkamp commented Oct 6, 2015

mm, this triggered me to re-read the documentation, 832127a is quite interesting, andy reason why the non-qualified classnames are converted to lowercase? What is the problem of using casing in the discriminator values?

@Ocramius
Copy link
Member

Ocramius commented Oct 6, 2015

@holtkamp I suggest digging into the git logs for that, and putting it in the docs once we have the "why"

@holtkamp
Copy link
Contributor

holtkamp commented Oct 6, 2015

@Ocramius, mm, appears this functionality is not as recent as I thought ;), digged around a bit, could not find any argumentation for using lower case non-qualified classnames. Only a similar question: 99e303e#commitcomment-3516763, @beberlei you remember why you choose the lowercase approach? Just being curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants