Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refere to : http://www.doctrine-project.org/jira/browse/DDC-1410 #161

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

armetiz commented Oct 20, 2011

No description provided.

Owner

guilhermeblanco commented Oct 20, 2011

Hi,

Patch looks awesome, but I'd rather suggest to have a test case that fails without the patch and pass after patch together with the code changes. That way we prevent from having regressions in the future. =)

Cheers,

Contributor

armetiz commented Oct 21, 2011

I have launched phpunit before my patch & after my patch. In both case no error appear.
I want to integrate the testCase below, but I'm not really familiar with PHPUnit testCase.

$queryBuilder = $entityManager->createQueryBuilder();
$queryBuilder->select ( "player, options" );
$queryBuilder->from ( "Player_Model_Entity_Player", "player");
$queryBuilder->where ("player.idPlayer = 12");
$queryBuilder->leftJoin ("player.options", "options", "WITH", "options.enabled = :enabled");
$queryBuilder->setParameter ("enabled", 1);

OptionA & OptionB & OptionC three entities.
User case :

OptionA.enabled = 1 & OptionB.enabled = 1 & OptionC.enabled = 1 : OK -
OptionA.enabled = 1 & OptionB.enabled = 0 & OptionC.enabled = 0 : OK -
OptionA.enabled = 1 & OptionB.enabled = 0 & OptionC.enabled = 1 : OK -
OptionA.enabled = 0 & OptionB.enabled = 1 & OptionC.enabled = 1 : KO - Fail compare to normal result.
OptionA.enabled = 0 & OptionB.enabled = 0 & OptionC.enabled = 0 : OK -

Owner

beberlei commented Nov 9, 2011

This was fixed already in DDC-1410

@beberlei beberlei closed this Nov 9, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment