added EntityRepository::getClassName() #175

Merged
merged 1 commit into from Nov 13, 2011

2 participants

@lsmith77
Doctrine member

added EntityRepository::getClassName() to fullfill the ObjectRepository interface

see doctrine/common#70

@stof stof commented on the diff Oct 25, 2011
lib/Doctrine/ORM/EntityRepository.php
@@ -226,6 +226,14 @@ class EntityRepository implements ObjectRepository
}
/**
+ * @return string
+ */
+ public function getClassName()
+ {
+ return $this->getEntityName();
@stof
Doctrine member
stof added a line comment Oct 25, 2011

actually, I think it should be done the opposite way, to be able to mark getEntityName as deprecated now that getClassName is in the interface

@lsmith77
Doctrine member
lsmith77 added a line comment Oct 25, 2011

yeah .. i wasn't sure .. figured maybe someone has overwritten getEntityName() already .. then again maybe in that case it should not apply to getClassName() ..

@lsmith77
Doctrine member
lsmith77 added a line comment Nov 13, 2011

@beberlei: just to make sure .. you agree with my approach?

also when will you merge doctrine/common#70 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@beberlei beberlei merged commit e9068a1 into doctrine:master Nov 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment