Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

association override #218

Closed
wants to merge 9 commits into from

6 participants

Fabio B. Silva Guilherme Blanco Benjamin Eberlei Michel Salib Alexander Christophe Coevoet
Fabio B. Silva

Hello All

This patch is one part of DDC-964 : http://www.doctrine-project.org/jira/browse/DDC-964
First part add suport for AssociationOverride.

I wrote this code based on java implementation :
http://docs.oracle.com/javaee/6/api/javax/persistence/AssociationOverride.html

Any sugestion are welcome

Thanks

Guilherme Blanco

The idea is awesome, but the patch can't be evaluated quickly.
There're thousands of possibilities and we can't merge blindly and open a can of worms.

I'll be evaluating the patch, but it takes time. I also wonder if @beberlei and @asm89 want to evaluate too.

Benjamin Eberlei
Owner

It looks very good, but its missing XML and YAML Driver support :-)

Fabio B. Silva

hello

I changed many things to implement the other drivers.
Please take a look again. //cc @guilhermeblanco, @beberlei

Michel Salib

Can't wait to see it merged. Any news ? //cc @guilhermeblanco, @beberlei

Fabio B. Silva

ping :)

Alexander
Collaborator

Nice PR! I'll try to sit down and thoroughly go through the code this week. On a quick scroll it looks nice.

@guilhermeblanco @beberlei Checked it out after the added commits?

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -498,7 +498,7 @@ class ClassMetadataInfo implements ClassMetadata
/**
* NamingStrategy determining the default column and table names
*
- * @var \Doctrine\ORM\NamingStrategy
+ * @var Doctrine\ORM\Mapping\NamingStrategy
Christophe Coevoet
stof added a note

you should keep tje leading \

Fabio B. Silva Owner

Done !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Fabio B. Silva

Hi :)

Any news about this one ?

Fabio B. Silva

i'm opening a new PR for this one

Fabio B. Silva FabioBatSilva deleted the branch
elHornair elHornair referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.