Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

association override #218

Closed
wants to merge 9 commits into from

6 participants

@FabioBatSilva

Hello All

This patch is one part of DDC-964 : http://www.doctrine-project.org/jira/browse/DDC-964
First part add suport for AssociationOverride.

I wrote this code based on java implementation :
http://docs.oracle.com/javaee/6/api/javax/persistence/AssociationOverride.html

Any sugestion are welcome

Thanks

@guilhermeblanco

The idea is awesome, but the patch can't be evaluated quickly.
There're thousands of possibilities and we can't merge blindly and open a can of worms.

I'll be evaluating the patch, but it takes time. I also wonder if @beberlei and @asm89 want to evaluate too.

@beberlei
Owner

It looks very good, but its missing XML and YAML Driver support :-)

@FabioBatSilva

hello

I changed many things to implement the other drivers.
Please take a look again. //cc @guilhermeblanco, @beberlei

@michelsalib

Can't wait to see it merged. Any news ? //cc @guilhermeblanco, @beberlei

@FabioBatSilva

ping :)

@asm89
Collaborator

Nice PR! I'll try to sit down and thoroughly go through the code this week. On a quick scroll it looks nice.

@guilhermeblanco @beberlei Checked it out after the added commits?

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -498,7 +498,7 @@ class ClassMetadataInfo implements ClassMetadata
/**
* NamingStrategy determining the default column and table names
*
- * @var \Doctrine\ORM\NamingStrategy
+ * @var Doctrine\ORM\Mapping\NamingStrategy
@stof
stof added a note

you should keep tje leading \

@FabioBatSilva Owner

Done !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@FabioBatSilva

Hi :)

Any news about this one ?

@FabioBatSilva

i'm opening a new PR for this one

@FabioBatSilva FabioBatSilva deleted the branch
@elHornair elHornair referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.