Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[DDC 1557] Support for DQL function on subselect #246

Merged
merged 3 commits into from Dec 29, 2011

Conversation

Projects
None yet
2 participants
Owner

FabioBatSilva commented Dec 29, 2011

This patch fix : DDC-1557
http://www.doctrine-project.org/jira/browse/DDC-1557

@guilhermeblanco, Please tell me if can I make something better. :)

Thanks ...

Owner

guilhermeblanco commented Dec 29, 2011

@FabioBatSilva It seems the EBNF should change then. The docblock is the place you should update to address this change.
Currently it is this one:

SimpleSelectExpression ::= StateFieldPathExpression | IdentificationVariable | ((AggregateExpression | "(" Subselect ")" | ScalarExpression) [["AS"] AliasResultVariable])

And it should be updated to this one:

SimpleSelectExpression ::= (StateFieldPathExpression | IdentificationVariable | FunctionDeclaration | AggregateExpression | "(" Subselect ")" | ScalarExpression) [["AS"] AliasResultVariable]
Owner

FabioBatSilva commented Dec 29, 2011

Done !
Please take a look @guilhermeblanco.

guilhermeblanco added a commit that referenced this pull request Dec 29, 2011

Merge pull request #246 from FabioBatSilva/DDC-1557
[DDC 1557] Support for DQL function on subselect

@guilhermeblanco guilhermeblanco merged commit e438979 into doctrine:master Dec 29, 2011

@FabioBatSilva FabioBatSilva deleted the FabioBatSilva:DDC-1557 branch Jan 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment