Fix DDC-1694 #317

Merged
merged 3 commits into from May 5, 2012

4 participants

@FabioBatSilva
Doctrine member

http://www.doctrine-project.org/jira/browse/DDC-1694

if I understand right
Probably this code will be replaced by Benjamin's Code Generator.

Any way, for now I think this is a valid issue..

@stof stof commented on an outdated diff Apr 1, 2012
lib/Doctrine/ORM/Tools/EntityGenerator.php
+ /**
+ * Hash-map for handle types
+ *
+ * @var array
+ */
+ private $typeAlias = array(
+ Type::DATETIMETZ => '\DateTime',
+ Type::DATETIME => '\DateTime',
+ Type::DATE => '\DateTime',
+ Type::TIME => '\DateTime',
+ Type::OBJECT => '\stdClass',
+ Type::BIGINT => 'integer',
+ Type::SMALLINT => 'integer',
+ Type::TEXT => 'string',
+ Type::BLOB => 'string',
+ Type::DECIMAL => 'double',
@stof
Doctrine member
stof added a note Apr 1, 2012

some IDE don't recognize it. you should use float which is the proper name for the type in PHP (is_double is only an alias for is_float)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@asm89
Doctrine member

@FabioBatSilva Can you rebase this PR?

@travisbot

This pull request passes (merged e997491 into bd41e69).

@FabioBatSilva
Doctrine member

Hi @asm89

Rebase done :)
I had a lot of conflicts, could you take a look again please ?

Thanks..

@beberlei beberlei merged commit 4ef552e into doctrine:master May 5, 2012
@asm89
Doctrine member

👍 Another one down.

@FabioBatSilva FabioBatSilva deleted the FabioBatSilva:DDC-1694 branch Jan 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment