Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fluent interface to persist #341

Closed
wants to merge 1 commit into from
Closed

Added fluent interface to persist #341

wants to merge 1 commit into from

Conversation

fixe
Copy link
Contributor

@fixe fixe commented Apr 24, 2012

No description provided.

@@ -494,6 +494,7 @@ public function close()
* this EntityManager as NEW. Do not pass detached entities to the persist operation.
*
* @param object $object The instance to make managed and persistent.
* @return object Entity Manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you returning "object" if you already know the instance class name?

@guilhermeblanco
Copy link
Member

Ok, this was discussed over and over and we agreed to not support this.
Unless @beberlei @romanb @asm89 @jwage @FabioBatSilva @Ocramius have strong arguments, I'd reject it.

@Ocramius
Copy link
Member

@FabioBatSilva
Copy link
Member

Hi @guilhermeblanco, I agree : 👎

@fixe
Copy link
Contributor Author

fixe commented Apr 24, 2012

Good enough. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants