Hydrator hotfix - time to think about keeping types for columns #347

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@rivaros
rivaros commented May 5, 2012

Line 251 - nobody cared to call convertToPHPValue($value, $this->_platform);

And I know why - it was hard to determine column type, easier to write $value. :)

... Because type is not in ResultSetMapping

... Because type is not in ClassMetadataInfo either

... Because column types are never considered in associations.

@travisbot

This pull request fails (merged 6fe926f into 4ef552e).

@rivaros
Member
rivaros commented on 6fe926f May 5, 2012

This hotfix is not for merging. It is more to show that we need a "type" attribute in JoinColumn.

@beberlei
Member
beberlei commented Jul 4, 2012

This is not helpful, we know of this problem, but that is not the fix for it.

@beberlei beberlei closed this Jul 4, 2012
@rivaros
rivaros commented Jul 6, 2012

As you see it was not a fix, but just a demo of problem. Good you know
it.

This is not helpful, we know of this problem, but that is not the fix for it.


Reply to this email directly or view it on GitHub:
#347 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment