Skip to content

Entities generator: constructor's template docblock #363

Merged
merged 1 commit into from Jun 15, 2012

4 participants

@gajdaw
gajdaw commented Jun 6, 2012

Missing constructor's docblock.

@stof stof commented on the diff Jun 6, 2012
lib/Doctrine/ORM/Tools/EntityGenerator.php
@@ -235,7 +235,10 @@ public function <methodName>()
* @var string
*/
private static $constructorMethodTemplate =
-'public function __construct()
+'/**
+ * Constructor
+ */
@stof
Doctrine member
stof added a note Jun 6, 2012

the indentation of the docblock is wrong.

@gajdaw
gajdaw added a note Jun 6, 2012

I run the command:

doctrine:generate:entities

and generated code is correct:

    /**
     * Constructor
     */
    public function __construct()
    {
        $this->groups = new \Doctrine\Common\Collections\ArrayCollection();
    }

I can not find any problem with indentation. Can you explain it?

@stof
Doctrine member
stof added a note Jun 6, 2012

ah sorry, I missed the space as the first line is not aligned with the others because of the opening quote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@travisbot

This pull request passes (merged b263a00 into 9445502).

@guilhermeblanco guilhermeblanco merged commit e8ad82c into doctrine:master Jun 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.