[DDC-1895] Fix fetch relation by id of association field #386

Merged
merged 1 commit into from Jul 3, 2012

Conversation

Projects
None yet
4 participants
@Burgov
Contributor

Burgov commented Jul 2, 2012

See issue notes for explaination: http://www.doctrine-project.org/jira/browse/DDC-1895

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jul 2, 2012

This pull request passes (merged acde0997 into 417b6b0).

This pull request passes (merged acde0997 into 417b6b0).

@Burgov

This comment has been minimized.

Show comment
Hide comment
@Burgov

Burgov Jul 3, 2012

Contributor

@guilhermeblanco your comment seems to have disappeared, but I've applied your suggested change

Can you change this piece of code to a switch?
We try to apply some rules that we are trying to get rid of all "else"s.

Contributor

Burgov commented Jul 3, 2012

@guilhermeblanco your comment seems to have disappeared, but I've applied your suggested change

Can you change this piece of code to a switch?
We try to apply some rules that we are trying to get rid of all "else"s.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Jul 3, 2012

This pull request passes (merged 5dc999a into 417b6b0).

This pull request passes (merged 5dc999a into 417b6b0).

guilhermeblanco added a commit that referenced this pull request Jul 3, 2012

Merge pull request #386 from SamsonIT/fix_fetch_relation_by_id_of_ass…
…ociation_field

[DDC-1895] Fix fetch relation by id of association field

@guilhermeblanco guilhermeblanco merged commit ab851ab into doctrine:2.1.x Jul 3, 2012

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Jul 4, 2012

Member

This was merged into 2.1.x? :(

Member

beberlei commented Jul 4, 2012

This was merged into 2.1.x? :(

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Jul 4, 2012

Member

@Burgov can you open against master again?

Member

beberlei commented Jul 4, 2012

@Burgov can you open against master again?

@Burgov Burgov referenced this pull request Jul 4, 2012

Merged

fixed DDC-1895 #389

@Burgov

This comment has been minimized.

Show comment
Hide comment
@Burgov

Burgov Jul 4, 2012

Contributor

@beberlei I opened it on 2.1 because I thought it would be merge into 2.3 later on. I've created a new PR for 2.3

Contributor

Burgov commented Jul 4, 2012

@beberlei I opened it on 2.1 because I thought it would be merge into 2.3 later on. I've created a new PR for 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment