Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DDC-1939 - Removing references to non-existing AssociationMapping class #407

Merged
merged 1 commit into from Jul 29, 2012

Conversation

Projects
None yet
3 participants
Owner

Ocramius commented Jul 24, 2012

This fixes DDC-1939, which is caused by an overlooked usage of Doctrine\ORM\Mapping\AssociationMapping, which was removed.

This pull request passes (merged aa0cb0b into 619d29a).

@beberlei beberlei commented on the diff Jul 24, 2012

lib/Doctrine/ORM/Persisters/ManyToManyPersister.php
@@ -198,7 +198,7 @@ protected function _getDeleteSQLParameters(PersistentCollection $coll)
}
// Composite identifier
- $sourceClass = $this->_em->getClassMetadata(get_class($mapping->getOwner()));
+ $sourceClass = $this->_em->getClassMetadata(get_class($coll->getOwner()));
@beberlei

beberlei Jul 24, 2012

Owner

intersting, this code is never executed if you can just change it this way.

@beberlei beberlei merged commit aa0cb0b into doctrine:master Jul 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment