[DDC-1872] Overriding Mapping Annotations #414

Merged
merged 3 commits into from Oct 6, 2012

Conversation

Projects
None yet
4 participants
Contributor

cordoval commented Jul 30, 2012

#412

Thanks

This pull request passes (merged 5d00824 into 00a5f18).

+ public function testAttributeOverridesMappingWithTrait()
+ {
+ if (!version_compare(PHP_VERSION, '5.4.0', '>=')) {
+ $this->markTestSkipped('Invalid PHP version, unable to run this test.');
@stof

stof Jul 30, 2012

Member

you should change this message to be a bit more friendly, explaining that this test is only for 5.4+. The current message could let think that using 5.3 to run the testsuite is wrong, which is absolutely not the case.

@cordoval

cordoval Aug 1, 2012

Contributor

@stof done

Contributor

cordoval commented Aug 1, 2012

done

This pull request passes (merged 221ab3b into 00a5f18).

beberlei added a commit that referenced this pull request Oct 6, 2012

Merge pull request #414 from cordoval/DDC-1872
[DDC-1872] Overriding Mapping Annotations

@beberlei beberlei merged commit a67a6aa into doctrine:master Oct 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment