Comment fixes #436
Merged
Comment fixes #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,10 +323,12 @@ public function commit($entity = null) | |||
|
|
|||
| // Collection deletions (deletions of complete collections) | |||
| foreach ($this->collectionDeletions as $collectionToDelete) { | |||
| /** @var PersistentCollection $collectionToDelete */ | |||
There was a problem hiding this comment.
We do not allow this. Please remove IDE dependant code.
|
Based on the IDE dependent code I might guess you're using PhpStorm? If so you can install the symfony2 code standard for phpcs and enable "PHP Code Sniffer validation" in the Inspections config of PhpStorm (or use phpcs from the command line). It catches a lot of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update method comments in UnitOfWork and fixes a typo in isCollectionScheduledForDeletion.
It also adds a missing use statement in getQuotedIdentifierColumnNames of ClassMetadateInfo.