Fixed some typo error in XML Exporter #444

Merged
merged 2 commits into from Oct 5, 2012

Conversation

Projects
None yet
3 participants
@goetas
Contributor

goetas commented Sep 13, 2012

No description provided.

$discriminatorColumnXml->addAttribute('name', $metadata->discriminatorColumn['name']);
$discriminatorColumnXml->addAttribute('type', $metadata->discriminatorColumn['type']);
- $discriminatorColumnXml->addAttribute('length', $metadata->discriminatorColumn['length']);
+ if(isset($metadata->discriminatorColumn['length'])){

This comment has been minimized.

Show comment Hide comment
@stof

stof Sep 13, 2012

Member

missing spaces after if and before {

@stof

stof Sep 13, 2012

Member

missing spaces after if and before {

@stof

This comment has been minimized.

Show comment Hide comment
@stof

stof Sep 13, 2012

Member

could you add a test for this to avoid regressions ?

Member

stof commented Sep 13, 2012

could you add a test for this to avoid regressions ?

@goetas

This comment has been minimized.

Show comment Hide comment
@goetas

goetas Sep 13, 2012

Contributor

i've fixed the if.

there is some problem to add a test. the problem is linked to another my pull request (#445).

Contributor

goetas commented Sep 13, 2012

i've fixed the if.

there is some problem to add a test. the problem is linked to another my pull request (#445).

@beberlei

This comment has been minimized.

Show comment Hide comment
@beberlei

beberlei Sep 17, 2012

Owner

Is this PR good for its own?

Owner

beberlei commented Sep 17, 2012

Is this PR good for its own?

@goetas

This comment has been minimized.

Show comment Hide comment
@goetas

goetas Sep 17, 2012

Contributor

the PR is ok, but i can't write the test

Contributor

goetas commented Sep 17, 2012

the PR is ok, but i can't write the test

beberlei added a commit that referenced this pull request Oct 5, 2012

Merge pull request #444 from goetas/xmlfix
Fixed some typo error in XML Exporter

@beberlei beberlei merged commit a5e043e into doctrine:master Oct 5, 2012

1 check failed

default The Travis build failed
Details

@goetas goetas deleted the goetas:xmlfix branch Aug 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment