Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

check for false as a return value from get_parent_class(), not null #481

Merged
merged 1 commit into from Oct 22, 2012

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Oct 16, 2012

MappingException::identifierRequired() and MappingException::classIsNotAValidEntityOrMappedSuperClass() both check for null, when they should check for false from get_parent_class().

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2082

@guilhermeblanco guilhermeblanco added a commit that referenced this pull request Oct 22, 2012

@guilhermeblanco guilhermeblanco Merge pull request #481 from beejeebus/master
check for false as a return value from get_parent_class(), not null
9d0b254

@guilhermeblanco guilhermeblanco merged commit 9d0b254 into doctrine:master Oct 22, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment