Skip to content

Fix DDC-2084 #486

Merged
merged 3 commits into from Nov 6, 2012

5 participants

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2091

@FabioBatSilva
Doctrine member

@Ocramius Indeed,

But seems not related..
Got the same erro in another build : https://travis-ci.org/#!/doctrine/doctrine2/jobs/2780074/L95

Any idea about what could be the reason ?

@guilhermeblanco
Doctrine member

@FabioBatSilva @Ocramius normally Seg faults happen in phpunit when you're comparing objects in assertEquals.

@FabioBatSilva
Doctrine member

Weird..
after rebase the build passes : https://travis-ci.org/#!/FabioBatSilva/doctrine2/builds/2921945

@guilhermeblanco guilhermeblanco and 1 other commented on an outdated diff Oct 27, 2012
lib/Doctrine/ORM/AbstractQuery.php
- if ( ! $value) {
- throw new \InvalidArgumentException(
- "Binding entities to query parameters only allowed for entities that have an identifier."
- );
+ return $value;
@guilhermeblanco
Doctrine member

This return is useless here. You can just remove it.

@FabioBatSilva
Doctrine member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof and 1 other commented on an outdated diff Oct 28, 2012
.../Doctrine/Tests/ORM/Functional/Ticket/DDC2084Test.php
@@ -0,0 +1,131 @@
+<?php
+
+namespace Doctrine\Tests\ORM\Functional\Ticket;
+
+
+require_once __DIR__ . '/../../../TestInit.php';
@stof
Doctrine member
stof added a note Oct 28, 2012

This require_once is useless so please remove it

@FabioBatSilva
Doctrine member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@guilhermeblanco
Doctrine member

Rebase?

@guilhermeblanco guilhermeblanco merged commit d6d5c34 into doctrine:master Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.