Skip to content

added fix for unsigned option in column defintion #500

Closed
wants to merge 83 commits into from
@sebastianbauer

Just checking in SchemaTool if unsigned option is set and take this value.

stof and others added some commits Jul 17, 2012
@stof stof Changed commands to use command.name in the help 3e53d9d
@guilhermeblanco guilhermeblanco Moved implementation from EntityRepository to EntityManager. This dec…
…ouples ER implementation from EM, as it should be.
5b55739
@guilhermeblanco guilhermeblanco Fixed DefaultRepositoryClassName which should follow the Persistence …
…interface, not ORM class.
2389f77
@igorw igorw [2.3] Use HelperSet in cli-config.php 2158a07
@guilhermeblanco guilhermeblanco Fixed is_subclass_of comparing an interface which brought our require…
…ment to 5.3.9. Changed to reflection approach which still keep us at the same dependency as before.
ac9df05
@stof stof Added the new DBAL 2.3 types in the EntityGenerator typehint map 369a30a
@beberlei beberlei Merge pull request #410 from igorw/helper-set
[2.3] Use HelperSet in cli-config.php
bd1e6ac
@beberlei beberlei Merge remote-tracking branch 'origin/2.3' into 2.3 13d32e6
@beberlei beberlei Merge remote-tracking branch 'origin/2.3' into 2.3 ef27721
@Ocramius Ocramius DDC-1939 - Removing references to non-existing AssociationMapping class dfa6ff6
@beberlei beberlei [DDC-1939] Add test for persistent collection delete with composite key e2c40dc
@beberlei beberlei Merge branch 'DDC-1939' into 2.3 d7bdae3
@schmittjoh schmittjoh added failing test for refresh with eager fetching e63575e
@beberlei beberlei [DDC-1964] Fix issue with refresh and and object hydrator not setting…
… field to null explicitly to override possible previous values.
7f68347
@beberlei beberlei Merge branch 'DDC-1964' into 2.3 7029d37
@Ocramius Ocramius DDC-1933 - Fixing cloning of QueryBuilder and adding related tests 1e2eca1
@beberlei beberlei [DDC-1937] Fix bug with apc and annotation caching using a workaround. 6dd3078
@beberlei beberlei Merge branch 'DDC-1937' into 2.3 1676cf2
@beberlei beberlei Bump dependencies c55394c
@beberlei beberlei Release 2.3.0-RC1 5527e12
@beberlei beberlei Bump dev version to 2.3.0 992b51e
@Majkl578 Majkl578 [DDC-1961] Fixed parameter type support in Parameter 3b3d762
@guilhermeblanco guilhermeblanco Merge pull request #416 from Majkl578/DDC-1961
[DDC-1961] Fixed parameter type support in Parameter
3f2ddc6
@beberlei beberlei Update EntityRepository and PersistentCollection to new Criteria#expr…
…() method instead of having to implement themselves.
c99c7b6
@beberlei beberlei Merge branch 'CriteriaExpressionBuilder' into 2.3 17862d9
Martin Meredith Create the setCustomHydrationMode function
This allows multiple hydrators to be set at once, and also allows for
the customHydrationMode options to be set via DoctrineORMModule
2e6b50b
@asm89 asm89 Fix setCustomHydrationModes + added test af08f05
@asm89 asm89 Merge branch 'config' into 2.3 971865f
@chEbba chEbba Fix ORMInvalidArgumentException factory methods with return instead o…
…f throw
3aaa90e
@FabioBatSilva FabioBatSilva Fix DDC-1977 9d909cd
@beberlei beberlei Merge pull request #427 from chEbba/return-exception
Fix ORMInvalidArgumentException factory methods with return instead of throw
48e9434
@beberlei beberlei Merge remote-tracking branch 'origin/master' into 2.3 131d300
@beberlei beberlei [DDC-1918] Fix weird results at the end of paginator when using fetch…
… joins
f4ba583
@beberlei beberlei Merge remote-tracking branch 'origin/2.3' into 2.3 8c1d643
@beberlei beberlei Merge branch 'DDC-1918' into 2.3 bdb36a7
@beberlei beberlei Revert "Merge remote-tracking branch 'origin/master' into 2.3"
This reverts commit 131d3003a0a5c46dd45c63ea9927e8f05e065a4f, reversing
changes made to 9d909cd583f5742364247f318afd74bade2c68f4.
114e233
@beberlei beberlei Bump dev version to 2.3.0 1a81444
@beberlei beberlei Release 2.3.0-RC2 d181fbc
@beberlei beberlei Release 2.3.0-RC2 9308afc
@beberlei beberlei Bump dev version to 2.3.0 bbf527a
@Josiah Josiah Added a failing test for DDC-2003 2597192
@Josiah Josiah Fixed DDC-2003 using closures to reference the functionality of the c…
…alling entity persister from the SQL value visitor.
366c6a7
@Josiah Josiah Removed the closure keyword as it isn't supported in PHP 5.3 0dcfabb
@Josiah Josiah Fixed formatting issues identified by Stof c76280b
@Josiah Josiah Refactored the SqlValueVisitor to move all type processing to the ent…
…ity persister.
9cdee12
@beberlei beberlei [DDC-2003] Remove unused variable 30ad1b0
@beberlei beberlei Merge branch 'DDC-2003' into 2.3 741080d
@beberlei beberlei Bump DBAL dependency 8edecfd
@beberlei beberlei Release 2.3.0-RC3 a96bbbb
@beberlei beberlei Bump dev version to 2.3.0 4d9f24b
Cas Update lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php
Allow 'nullable' attribute to be exported for fields, something which already worked in YamlExport. This addition saved me a lot of time during development, not having to manually re-factor after each export.

Don't know why this was missing, maybe it's me who is missing something, so let me know ;)
53e164b
@beberlei beberlei Merge branch 'DDC-2027' into 2.3 387516f
@FabioBatSilva FabioBatSilva remove duplicate code 0da0d02
@beberlei beberlei Merge branch 'DDC-2026' into 2.3 3fd8392
@Powerhamster Powerhamster Several fixes for comments
updated @param and @throws annotations
85e5398
@Powerhamster Powerhamster added missing use statement d7da012
@beberlei beberlei Merge branch 'DDC-2014' into 2.3 c2b82fa
Stefano Rodriguez Fixes PersistentCollection::matching() when collection is not initial…
…ized and there are NEW entities in the collection
18a7fc5
Stefano Rodriguez Added a failing test case on PersistentCollection::matching() when co…
…llection is not initialized and there are NEW entities in the collection
44a56e8
Stefano Rodriguez use of assertCount 586aea0
@beberlei beberlei Merge branch 'DDC-2015' into 2.3 2353736
@beberlei beberlei Update dependencies 3294900
@beberlei beberlei Adjust MysqlSchemaToolTest to DBAL changes 75e968b
@beberlei beberlei Release 2.3.0-RC4 477642a
@beberlei beberlei Bump dev version to 2.3.0 c610131
@beberlei beberlei Bump versions 585c9fd
@beberlei beberlei Release 2.3.0 b5e19dc
@beberlei beberlei Bump dev version to 2.3.1 ea2b288
@FabioBatSilva FabioBatSilva Fix DDC-2012 084101e
@beberlei beberlei Merge branch 'DDC-2012' into 2.3 04262e2
@FabioBatSilva FabioBatSilva Fix test case c60e652
@beberlei beberlei [DDC-2059] Fix column and foreign key interfering with each other dur…
…ing reverse engineering.
4109f22
@beberlei beberlei Merge branch 'DDC-2059' into 2.3 518357d
Marcin Radziwoński Fixed unique-constraint name in XML Exporter abd1137
@beberlei beberlei Merge branch 'DDC-2044' into 2.3 825a68b
@goetas goetas typo fix 8b2c92a
@goetas goetas spaces cb0cdde
@beberlei beberlei Merge branch 'DDC-2028' into 2.3 564ec1e
@jakoch jakoch fix typo 1988944
@okovalov okovalov Fixed bug with comment option not being added to column. 2e5d741
@beberlei beberlei Merge branch 'DDC-2068' into 2.3 e8412b8
@beberlei beberlei [DDC-2067] Refactor and fix bug in boolean evaluation inside XML Driver. 26cfbdd
@beberlei beberlei Merge branch 'DDC-2067' into 2.3 6bad010
@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2120

@Ocramius
Doctrine member
Ocramius commented Nov 4, 2012

@sebastianbauer could you please add a test that shows what the problem you attempt to fix is?

Also, please don't merge upstream next time: instead, rebase. If you can, please squash those commits so that the merges don't cause a mess once this PR is merged :)

@Ocramius Ocramius commented on an outdated diff Nov 4, 2012
lib/Doctrine/ORM/Tools/SchemaTool.php
@@ -389,6 +389,11 @@ private function gatherColumn($class, array $mapping, Table $table)
unset($mapping['options']['comment']);
}
+ if (isset($mapping['options']['unsigned'])) {
@Ocramius
Doctrine member
Ocramius added a note Nov 4, 2012

Missing empty line before this if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sebastianbauer
@Ocramius
Doctrine member
Ocramius commented Nov 4, 2012

@sebastianbauer no worries :) Just push the changes to the same branch and the PR will be updated automatically. Focus on the test only eventually. If you cannot manage to squash the commits, it can be merged manually.

@sebastianbauer

I have to cleanup my branch. Trying to fix the commits needs more time when doing that for the first time. ;) Hope to have a update tomorrow afternoon.

@sebastianbauer

Sorry, my repo is totally broken now. ;) I just will send a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.