Fix and test for DDC-2073 #508

Merged
merged 2 commits into from Nov 6, 2012

3 participants

@mnapoli

Fix and test for DDC-2073.

Ticket extract:

PersistentCollection::matching() always returns empty collection, when passed criteria's expression is created using ExpressionBuilder::isNull()
This happens because expression created by ExpressionBuilder::isNull() is wrongly translated to SQL using '=' operator instead of 'IS NULL'.
If the collection is already loaded, result is as expected.

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2129

@mnapoli

Weird, it seems that the Travis worker crashed: https://travis-ci.org/#!/doctrine/doctrine2/jobs/3082212

All tests are OK, but the PHP 5.3/pgsql worker has crashed

@mnapoli

OK the build has been relaunched, everything is good!

@guilhermeblanco guilhermeblanco merged commit 09d53f0 into doctrine:master Nov 6, 2012

1 check passed

Details default The Travis build passed
@mnapoli mnapoli deleted the mnapoli:DDC-2073 branch Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment