Skip to content

Fix for Doctrine\ORM\Tools\EntityGenerator not picking the correct singular of some plurals #520

Closed
wants to merge 2 commits into from

6 participants

@jbergler

When generating stub method names words like entries became entrie when they should have become entry.

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2160

@Ocramius
Doctrine member

@jbergler can you add a test case for this one?

@jbergler

@Ocramius I've updated the existing test case, slightly awkward use of some words to fit the criteria, but they are tests nonetheless.

@Ocramius
Doctrine member

@jbergler looks good to me

@stof
Doctrine member
stof commented Nov 22, 2012

Well, why handling only 1 particular case of irregular plural ? If you start supporting them, it should support all possible cases

@jbergler
@Ocramius
Doctrine member

@jbergler are you sure the inflector is the right place for this?

@jbergler
@Ocramius
Doctrine member
@gm-olivier

In addition of companies/companie, I was hit by addresses/addresse and bonuses/bonuse.

Personally, I would be satisfied with a property that lets me override the singular form (or the method names) in the YAML.

@beberlei
Doctrine member
beberlei commented Jan 6, 2013

See notes on implementation in GH-530

@beberlei beberlei closed this Jan 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.