[DDC-2172] Fix EntityGenerator get literal type #526

Merged
merged 3 commits into from Nov 27, 2012

Conversation

Projects
None yet
3 participants
@doctrinebot

This comment has been minimized.

Show comment
Hide comment
@doctrinebot

doctrinebot Nov 27, 2012

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2174

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2174

-
- default:
- throw new \InvalidArgumentException('Invalid provided InheritanceType: ' . $type);
+ if( ! isset(self::$inheritanceTypeMap[$type])) {

This comment has been minimized.

@guilhermeblanco

guilhermeblanco Nov 27, 2012

Member

Missing space between if and (.

@guilhermeblanco

guilhermeblanco Nov 27, 2012

Member

Missing space between if and (.

-
- default:
- throw new \InvalidArgumentException('Invalid provided ChangeTrackingPolicy: ' . $policy);
+ if( ! isset(self::$changeTrackingPolicyMap[$type])) {

This comment has been minimized.

@guilhermeblanco

guilhermeblanco Nov 27, 2012

Member

And here

-
- default:
- throw new \InvalidArgumentException('Invalid provided IdGeneratorType: ' . $type);
+ if( ! isset(self::$generatorStrategyMap[$type])) {

This comment has been minimized.

@guilhermeblanco

guilhermeblanco Nov 27, 2012

Member

Also here

@guilhermeblanco

This comment has been minimized.

Show comment
Hide comment
@guilhermeblanco

guilhermeblanco Nov 27, 2012

Member

Very minor updates and I'm fine to merge

Member

guilhermeblanco commented Nov 27, 2012

Very minor updates and I'm fine to merge

@FabioBatSilva

This comment has been minimized.

Show comment
Hide comment
Member

FabioBatSilva commented Nov 27, 2012

Done !!!

Thanks @guilhermeblanco

guilhermeblanco added a commit that referenced this pull request Nov 27, 2012

Merge pull request #526 from FabioBatSilva/DDC-2172
[DDC-2172] Fix EntityGenerator get literal type

@guilhermeblanco guilhermeblanco merged commit 29f0b67 into doctrine:master Nov 27, 2012

1 check passed

default The Travis build passed
Details

@FabioBatSilva FabioBatSilva deleted the FabioBatSilva:DDC-2172 branch Jan 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment