[DDC-2182] Options join columns #529

Merged
merged 3 commits into from Dec 4, 2012

Projects

None yet

4 participants

@francisbesset
Contributor

When a columns as the options with unsigned at true, this options is not passed to the joinColumn.
This PR fix this.

Francis Besset Fixed typo 56b230a
@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2182

@beberlei
Member
beberlei commented Dec 4, 2012

For one time models that are necessary for a specific test only we normally don't create a new Models directory. Can you move the regression test to tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2182Test.php and inline the entities there as DDC2182Option...? You can take a look at similar tests in that folder.

@beberlei beberlei merged commit df1336d into doctrine:master Dec 4, 2012

1 check passed

default The Travis build passed
Details
@jonathaningram
Contributor

@francisbesset you are a legend! Thank you for fixing this. I literally just started doing this and thought I'd check first. Much appreciated. @beberlei I think this can be closed now http://doctrine-project.org/jira/browse/DBAL-394 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment