[DDC-2196] Improved "extendability" of EntityManager #535

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

mnapoli commented Dec 14, 2012

DDC-2196 EntityManager can't be extended easily

EntityManager::create now uses "new static" instead of "new EntityManager"

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2197

Contributor

mnapoli commented Dec 14, 2012

How can I do to avoid the bot to create a new Jira issue for every pull request?

Member

stof commented Dec 14, 2012

you cannot. This is intended as @beberlei prefers to use JIRA to track pending work

Baachi commented Dec 14, 2012

@stof Maybe mark the EntityManager as final?

Contributor

mnapoli commented Dec 14, 2012

@stof I'm not questioning Jira, it's just that there's already an issue open and I referenced it in the title, but the bot still creates a new (useless) ticket.

@Baachi I think he was refering my question (not the PR)

Baachi commented Dec 14, 2012

@mnapoli You should not extend the EntityManager, because it has some side effects.
And BTW have you looked at #524?

Contributor

mnapoli commented Dec 14, 2012

@Baachi Thanks I didn't see #514 indeed. So to sum up there is no way to extend the EntityManager, either by inheritance or by decoration?

And I'm curious of what the side effects are?

Owner

beberlei commented Dec 16, 2012

@mnapoli we want to prevent fiddiling with the EntityManager API, because its used internally in some places and requires to work exactly that way. We want to prevent weird bugs in user applications this way.

@beberlei beberlei closed this Dec 16, 2012

@mnapoli mnapoli deleted the mnapoli:DDC-2196 branch Nov 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment