[DDC-2234] FUNCTION() IS NULL comparison #551

Merged
merged 3 commits into from Jan 20, 2013

Conversation

Projects
None yet
5 participants

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2247

@stof stof and 1 other commented on an outdated diff Jan 19, 2013

lib/Doctrine/ORM/Query/Parser.php
@@ -3085,24 +3101,43 @@ public function LikeExpression()
}
/**
- * NullComparisonExpression ::= (SingleValuedPathExpression | InputParameter) "IS" ["NOT"] "NULL"
+ * NullComparisonExpression ::= InputParameter | NullIfExpression | CoalesceExpression | SingleValuedPathExpression "IS" ["NOT"] "NULL"
@stof

stof Jan 19, 2013

Member

you need to keep the braces

@FabioBatSilva

FabioBatSilva Jan 19, 2013

Owner

Hi @stof

Not sure about the grammar here,
NullComparisonExpression does not parse the braces

@stof

stof Jan 19, 2013

Member

Thses braces are grouping braces (like braces in regexes), not braces in the expression (you need to quote them for that)

@FabioBatSilva

FabioBatSilva Jan 19, 2013

Owner

Done, Thanks for explaining @stof

Owner

guilhermeblanco commented Jan 19, 2013

It seems you broke NOT EXISTS functionality

Owner

FabioBatSilva commented Jan 19, 2013

hi @guilhermeblanco

Looks like it works
There is a test in LanguageRecognitionTest, also i have added a new one into SelectSqlGenerationTest.

beberlei merged commit 916424a into doctrine:master Jan 20, 2013

1 check passed

default The Travis build passed
Details

FabioBatSilva deleted the FabioBatSilva:DDC-2234 branch Jan 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment