New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAVING clause with variable and *, / math operators #5598

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@Jean85
Contributor

Jean85 commented Jan 8, 2016

This is integrated and completed in #5599

I've produced a test for bug #4764

As this regression highlights, this bug happens only with the * and / math operators used in the HAVING clause with variables from the SELECT clause; + and - math operators are fine.

Input DQL:

SELECT COUNT(u.name) AS countName FROM Doctrine\Tests\Models\CMS\CmsUser u HAVING 1  / countName > 0

Expected:

SELECT COUNT(c0_.name) AS sclr_0 FROM cms_users c0_ HAVING 1 / sclr_0 > 0

Instead:

SELECT COUNT(c0_.name) AS sclr_0 FROM cms_users c0_ HAVING 1 / countName > 0

@deeky666 deeky666 changed the title from [WIP][Regression] HAVING clause with variable and *, / math operators to HAVING clause with variable and *, / math operators Jan 8, 2016

@Jean85

This comment has been minimized.

Show comment
Hide comment
@Jean85

Jean85 Jan 14, 2016

Contributor

Superseeded by #5598
Closing this, thanks @zeroedin-bill

Contributor

Jean85 commented Jan 14, 2016

Superseeded by #5598
Closing this, thanks @zeroedin-bill

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Jan 16, 2016

Member

Linking #5599

Member

Ocramius commented Jan 16, 2016

Linking #5599

@Ocramius Ocramius added this to the 2.5.5 milestone Jan 16, 2016

Ocramius added a commit that referenced this pull request Jan 16, 2016

Merge pull request #5599 from zeroedin-bill/fix/5598-having-regressio…
…n-fix

Fix #5598 issue with /, * in DQL not translating query components properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment