Added ability to eagerly load referenced entities with subclasses #613

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

stefankleff commented Mar 13, 2013

This is a rather ugly implementation. But maybe someone knows how to do it in a better way ;)

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2349

Owner

beberlei commented Mar 14, 2013

This is the worst hack i have seen in quite some time ;-)

  1. I dont like the extra property. It should be avoided
  2. I dont like the extra loop, why doesnt it work with the existing loading?
Owner

Ocramius commented Mar 14, 2013

I told him to open the PR to gather ideas :) Isn't meant to be merged

Contributor

stefankleff commented Mar 14, 2013

This is just some kind of proof of concept. The current "implementation" is kept as easy as possible to show that it is possible to eager load the associated entities. I don't like the way I did this neither. And regarding you points: Full ack ;)

Owner

beberlei commented Apr 6, 2013

I don't want to complicate this any more than it is already, and inheritance just has this performance hits. If you can come up with a more clean PR, please open one.

@beberlei beberlei closed this Apr 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment