Skip to content

[DDC-2188] Fix arithmetic priority #618

Merged
merged 1 commit into from Apr 6, 2013

5 participants

@FabioBatSilva
Doctrine member

Hi guys,

This patch fix DDC-2188,
Not sure if it could be considered a BC break.

Cheers

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2355

@Ocramius
Doctrine member

@FabioBatSilva yes, this is a break, but people using this were relying on a completely broken feature anyway.

@guilhermeblanco
Doctrine member

I'd vote to merge since this is a bug and relying on a broken behavior is conceptually wrong.

@beberlei beberlei merged commit fe238d0 into doctrine:master Apr 6, 2013

1 check passed

Details default The Travis build passed
@beberlei
Doctrine member
beberlei commented Apr 6, 2013

I merge, for 2.3 or 2.4 only?

@Ocramius
Doctrine member
Ocramius commented Apr 6, 2013

@beberlei it's a break, keep it away from 2.3 imo

@beberlei
Doctrine member
beberlei commented Apr 6, 2013

@FabioBatSilva if its a break, can you document this for the UPGRADE file?

@FabioBatSilva
Doctrine member

@beberlei Sure,
Done here : 8109db0

@FabioBatSilva FabioBatSilva deleted the FabioBatSilva:DDC-2188 branch Apr 6, 2013
@beberlei
Doctrine member
beberlei commented Apr 6, 2013

@FabioBatSilva thanks, but sometihng went wrong. First the SQL misses the FROM, also the parenthis in the second example look weird, shouldnt it be 100/(2+2) ?

@FabioBatSilva
Doctrine member

Sorry guys... fixed : 2ad6565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.