Skip to content

[Paginator]Add hidden field ordering for postgresql #640

Merged
merged 4 commits into from Jun 25, 2013

7 participants

@denkiryokuhatsuden

In postgresql environment, when some hidden fields are used in orderBy clause,
they're not property added because $rsm->scalarMappings don't have information about them.

This change fixes above.

I'm afraid I'm not sure which branch this will be merged, but anyway here's a patch.

@denkiryokuhatsuden denkiryokuhatsuden Add hidden field ordering for postgresql
In postgresql environment, when some hidden fields are used in orderBy clause,
they're not property added because $rsm->scalarMappings don't have information about them.
3e8796f
@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2385

@Ocramius
Doctrine member
Ocramius commented Apr 2, 2013

@denkiryokuhatsuden this kind of hotfix needs a failing test first

@denkiryokuhatsuden
denkiryokuha... added some commits Apr 3, 2013
@denkiryokuhatsuden

@Ocramius Is this acceptable?

@kimhemsoe
Doctrine member

If we start doing stuff like this. Why not move it the platform. Could possible also open the door of some optimization on certian platforms. Like big results and mysql makes the pagenation close to useless atm. (Mysql is very happy at creating temp tables which when big enough will end up being writened to the disk)

@maria-p
maria-p commented Jun 24, 2013

@Ocramius any updates on this?

@Ocramius
Doctrine member

@modeofdeath I cannot merge it myself

@guilhermeblanco guilhermeblanco merged commit 20e5d98 into doctrine:master Jun 25, 2013

1 check passed

Details default The Travis build passed
@beberlei
Doctrine member

@kimhemsoe do you accept the challenge? I would love to see this kind of instanceof madness be moved somewhere, however its not so easy in the platforms. This code needs to be in ORM, sort of strategies for pagination.

@kimhemsoe
Doctrine member

@beberlei Possible, can give it a shot. But you know my slowness :) So.. what you are saying is that ORM "need" some kind "platform" knowledge aswell, for lack of better term. A place where we can put platform optimizens for all of the ORM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.